Decoupling complex work is always not easy, and sometimes I get too into the implementation and forget to take a step back to see how my PRs look like to reviewers. Noting down some feedback & tips I got from my awesome team.
First conversation with Nathan on this topic:
- Incremental approach is much more approachable for both author and reviewers
- 264 lines is a good first PR to kick off the feedback & improvement cycle compared with 878 lines.
- Smaller PRs will save us lots of back-and-forth over the feedback & improvement cycle.
First conversation with Ema on this topic:
- Take some steps back at the beginning to plan out what subtasks are out there
- Include in the first PR what’s the plan, so that reviewers have the full road map in mind
- I started from easiest to hardest 😂 In most cases it’s better to start from hardest